[Asterisk-code-review] features: Add transfer initiation options. (asterisk[master])

[Kevin Harwell]

Attention is currently required from: N A, Richard Mudgett.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18001 )

Change subject: features: Add transfer initiation options.
......................................................................


Patch Set 5: Code-Review-1

(4 comments)

File main/bridge_basic.c:

https://gerrit.asterisk.org/c/asterisk/+/18001/comment/0e2ca596_0dde0e4d 
PS5, Line 1476: 	ast_string_field_set(props, exten, get_transfer_exten(transferer, NULL));
Do you really need to set prop->exten here? It appears to be overwritten not long after this. Matter of fact I think most of the changes in this file can be contained within just grab_transfer. See other comments below.


https://gerrit.asterisk.org/c/asterisk/+/18001/comment/4700bc3f_662d03a3 
PS5, Line 3189: 	if (!ast_strlen_zero(extenoverride)) {
Option 1: I believe you can just call extenoverride = get_transfer_exten(chan, exten) here without having to pass it in since both calling functions use same data to call it.

If you go this route you'd probably need to move it to be within the channel lock section just below.


https://gerrit.asterisk.org/c/asterisk/+/18001/comment/a21aad8e_f755ad29 
PS5, Line 3386: 	if (grab_transfer(bridge_channel->chan, exten, sizeof(exten), props->context, props->exten)) {
Option 2: I _think_ you can just pass result of get_transfer_exten here vs setting it on props.


https://gerrit.asterisk.org/c/asterisk/+/18001/comment/e0e89a58_e7f0d075 
PS5, Line 3400: 	ast_string_field_set(props, exten, exten);
Overwritten here after being set in attended_transfer_properties_alloc



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18001
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ibff309caa459a2b958706f2ed0ca393b1ef502e3
Gerrit-Change-Number: 18001
Gerrit-PatchSet: 5
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 02 Jun 2022 16:52:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220602/4ed4b121/attachment.html>