[Asterisk-code-review] res_pjsip: Add 100rel option "use_if_supported" (asterisk[16])

[N A]

Attention is currently required from: Maximilian Fridrich.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18838 )

Change subject: res_pjsip: Add 100rel option "use_if_supported"
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

File res/res_pjsip/pjsip_config.xml:

https://gerrit.asterisk.org/c/asterisk/+/18838/comment/8a8fbdb1_27917c85 
PS1, Line 39: 						</enumlist>
Some explanation of the difference between required, yes, and use_if_supported might be useful, especially now that there are several similar options., e.g. per the synopsis, "yes" allow support might seem the same as use_if_supported, and "restricted" vs "yes" also isn't intuitive.

So maybe a sentence for each would be good.


File res/res_pjsip/pjsip_configuration.c:

https://gerrit.asterisk.org/c/asterisk/+/18838/comment/2d868e0d_9ff01847 
PS1, Line 192: 	} else if (ast_false(var->value)){
Missing space between close paren and brace



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18838
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Id6d95ffa8f00dab118e0b386146e99f254f287ad
Gerrit-Change-Number: 18838
Gerrit-PatchSet: 1
Gerrit-Owner: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Comment-Date: Tue, 26 Jul 2022 14:07:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220726/a4d20687/attachment-0001.html>