[Asterisk-code-review] res_pjsip: Add 100rel option "use_if_supported" (asterisk[16])

[Joshua Colp]

Attention is currently required from: Maximilian Fridrich.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18838 )

Change subject: res_pjsip: Add 100rel option "use_if_supported"
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/18838/comment/ad521a85_98498ece 
PS1, Line 7: res_pjsip: Add 100rel option "use_if_supported"
I'm not a fan of use_if_supported as an option. I think "peer_supported" makes more sense.


Patchset:

PS1: 
This needs a CHANGES[1] entry as well.

[1] https://wiki.asterisk.org/wiki/display/AST/CHANGES+and+UPGRADE.txt


File include/asterisk/res_pjsip.h:

https://gerrit.asterisk.org/c/asterisk/+/18838/comment/86d10510_56958485 
PS1, Line 896: 	enum ast_sip_100rel_mode rel100;
This should go at the end of the structure.


File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/18838/comment/db0db70d_57efc0ac 
PS1, Line 3805: 	for (i = 0; i < rdata->msg_info.supported->count; ++i) {
If endpoint->rel100 isn't USE_IF_SUPPORTED this for loop doesn't need to occur, and in the for loop you can just set options and break out. There's no need for peer_100rel.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18838
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Id6d95ffa8f00dab118e0b386146e99f254f287ad
Gerrit-Change-Number: 18838
Gerrit-PatchSet: 1
Gerrit-Owner: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Comment-Date: Tue, 26 Jul 2022 14:45:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220726/16b3b77c/attachment-0001.html>