[Asterisk-code-review] res_redisd: add REDIS support modules to send asterisk DeviceState up... (asterisk[master])

[Alec Davis]

Attention is currently required from: Sean Bright, Joshua Colp, N A.
Alec Davis has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18829 )

Change subject: res_redisd: add REDIS support modules to send asterisk DeviceState updates to a REDIS server
......................................................................


Patch Set 8:

(5 comments)

Patchset:

PS8: 
Thanks Sean


File configs/samples/redisd.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/18829/comment/4f862902_a8cd247f 
PS7, Line 1: [general]
> For config files like this, I would prefer to see things lined up using all spaces instead of tabs.
Done. serves me right for copying statsd.conf


https://gerrit.asterisk.org/c/asterisk/+/18829/comment/c4f11953_68ce0d1a 
PS7, Line 6: ;dbname = 0			; DB to select, default = 0
> How about 'database' or 'database_name?'
Redis refers to the databases by index, thus the config option is now 'database_index'


https://gerrit.asterisk.org/c/asterisk/+/18829/comment/58842a0a_eeaa2557 
PS7, Line 8: bgsave = yes			; When set to yes, initiate a Background save when unloading module, default=no
> How about 'background_save_on_unload?'
Done


File res/res_redis_device_state.c:

https://gerrit.asterisk.org/c/asterisk/+/18829/comment/c58fffeb_8f14063c 
PS7, Line 88:         device_state_sub = stasis_subscribe(ast_device_state_topic_all(), device_state_cb, NULL);
            :         if (!device_state_sub) {
            : 		unload_module();
            : 		return AST_MODULE_LOAD_DECLINE;
            : 	}
            : 
            :         stasis_subscription_accept_message_type(device_state_sub, ast_device_state_message_type());
            :         stasis_subscription_set_filter(device_state_sub, STASIS_SUBSCRIPTION_FILTER_SELECTIVE);
            : 
            :         return AST_MODULE_LOAD_SUCCESS;
> Leading whitespace got a little funky here.
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18829
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifdf4d33d2a2a5fd044fac13b201c7437de34ba6a
Gerrit-Change-Number: 18829
Gerrit-PatchSet: 8
Gerrit-Owner: Alec Davis <alec at bdt.co.nz>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Mon, 25 Jul 2022 01:03:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220724/539d90ce/attachment.html>