[Asterisk-code-review] res_redisd: add REDIS support modules to send asterisk DeviceState up... (asterisk[master])

[Alec Davis]

Attention is currently required from: Sean Bright, Joshua Colp, N A.
Alec Davis has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18829 )

Change subject: res_redisd: add REDIS support modules to send asterisk DeviceState updates to a REDIS server
......................................................................


Patch Set 8:

(2 comments)

Patchset:

PS8: 
Changes as suggested.

Regarding collapsing into 1 module;

I followed the res_statsd/res_chan_stats concept of split modules.
Which had one to communicate with the statsd server, the other subscribed to channel caching topic and issued metric

Also all the REDIS_REPLY logic would then have to be duplicated when dialplan functions are created.

Alec


File include/asterisk/redisd.h:

https://gerrit.asterisk.org/c/asterisk/+/18829/comment/e4813f1b_fa30f96f 
PS7, Line 48: AST_OPTIONAL_API(void, ast_redisd_command, (const char *command, const char *key_path, const char *key_value, char *return_buffer, size_t return_buffwe_len), {});
> I do not think this is good API for all of Asterisk (it only allows for a single Redis connection, f […]
Multiple connections are possible.

We have some dialplan functions that call the same API to manipulated other REDIS keys. We initially had file descriptor leakage, hence the debug socket_fd throughout.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18829
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifdf4d33d2a2a5fd044fac13b201c7437de34ba6a
Gerrit-Change-Number: 18829
Gerrit-PatchSet: 8
Gerrit-Owner: Alec Davis <alec at bdt.co.nz>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Mon, 25 Jul 2022 00:20:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220724/def98d79/attachment-0001.html>