[Asterisk-code-review] pbx_variables: Add variable registration and validation (asterisk[master])

[Sean Bright]

Attention is currently required from: N A, Joshua Colp, George Joseph, Kevin Harwell.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17792 )

Change subject: pbx_variables: Add variable registration and validation
......................................................................


Patch Set 6:

(1 comment)

Patchset:

PS6: 
> such as allowing for validation of variable sets and having a more robust process for dealing with Asterisk variables in general

I don't see how this patch does that. It just appears to allow for registering the existence of variables and optionally preventing them from being assigned from 'user' code.

Regardless I didn't intend to rehash this whole discussion on Gerrit (I've already left a handful of comments previously), I just felt when looking over it again after the most recent update that making the variables explicitly handled in pbx_variables.c:ast_str_retrieve_variable top-level XML nodes would get you 99% of what you get in this patch (the ability to view these variables with a CLI command) in a simpler and more elegant way.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17792
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iad3b8d9833c7d9debe04aca59260d7316c3ad28c
Gerrit-Change-Number: 17792
Gerrit-PatchSet: 6
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <default.enum at gmail.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Kevin Harwell <default.enum at gmail.com>
Gerrit-Comment-Date: Sat, 23 Jul 2022 15:22:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220723/c9ce2694/attachment.html>