[Asterisk-code-review] res_redisd: REDIS support to send DeviceState updates to REDIS server (asterisk[master])

Alec Davis asteriskteam at digium.com
Thu Jul 21 19:15:51 CDT 2022


Attention is currently required from: N A.
Alec Davis has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18829 )

Change subject: res_redisd: REDIS support to send DeviceState updates to REDIS server
......................................................................


Patch Set 2:

(2 comments)

Patchset:

PS1: 
> Look at the line diff counts for your patch set. […]
configure attributed to most of these changes

Reffering to https://wiki.asterisk.org/wiki/display/AST/Build+System+Architecture

it says it should be included as quoted below, is this not the case?

run ./bootstrap.sh to regenerate ./configure and ./include/asterisk/autoconfig.h.in (both of which must be checked in if submitting a patch).


Patchset:

PS2: 
I'm not changing 10000 lines, but how do I exclude files in the automatic upload done by 'git review'.

It seem like there are 2 I don't want included.
#       modified:   menuselect/configure
#       modified:   configure

Regarding the testing with asterisk 16, this code is deployed on a production box running 16.

But I also have a test box running master which I am submitting these reviews from.
 
Alec



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18829
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifdf4d33d2a2a5fd044fac13b201c7437de34ba6a
Gerrit-Change-Number: 18829
Gerrit-PatchSet: 2
Gerrit-Owner: Alec Davis <alec at bdt.co.nz>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Fri, 22 Jul 2022 00:15:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Alec Davis <alec at bdt.co.nz>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220721/88903b25/attachment.html>


More information about the asterisk-code-review mailing list