[Asterisk-code-review] res_redisd: REDIS support to send DeviceState updates to REDIS server (asterisk[master])

[N A]

Attention is currently required from: Alec Davis.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18829 )

Change subject: res_redisd: REDIS support to send DeviceState updates to REDIS server
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

Patchset:

PS1: 
> See Comments below regarding addition files
Look at the line diff counts for your patch set. Is your code change really changing 10,000 lines? It seemed like you might have accidentally applied your change against an old version of those files. Most of those changes have nothing to do with redis or your change. They seem to be reverting previous commits.

You said you tested against 16, but this is the master branch, not 16, so potentially some of the files might not be the same. I would double check those and rebase your patches if needed.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18829
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifdf4d33d2a2a5fd044fac13b201c7437de34ba6a
Gerrit-Change-Number: 18829
Gerrit-PatchSet: 2
Gerrit-Owner: Alec Davis <alec at bdt.co.nz>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Alec Davis <alec at bdt.co.nz>
Gerrit-Comment-Date: Thu, 21 Jul 2022 23:57:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Alec Davis <alec at bdt.co.nz>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220721/f8bb410d/attachment.html>