[Asterisk-code-review] res_pjsip_outbound_registration: Show time until expiration (asterisk[master])

N A asteriskteam at digium.com
Mon Jan 31 06:38:08 CST 2022


Attention is currently required from: George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17789 )

Change subject: res_pjsip_outbound_registration: Show time until expiration
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2: 
> Doesn't look right.  See: […]
I think the difference in spacing is caused by printf, .e.g
%-16s %s%d%s

Putting them together would require changing %-16s to %s I think, not sure if that would be acceptable or not...

Also, do you know where the ======= gets printed? I can't find that in any of the relevant functions.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17789
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic4fea15a1a1056c424416def49d1ca8e776c0483
Gerrit-Change-Number: 17789
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 31 Jan 2022 12:38:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220131/84b1f210/attachment.html>


More information about the asterisk-code-review mailing list