[Asterisk-code-review] res_pjsip_outbound_registration: Show time until expiration (asterisk[master])

George Joseph asteriskteam at digium.com
Mon Jan 31 06:30:08 CST 2022


Attention is currently required from: N A.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17789 )

Change subject: res_pjsip_outbound_registration: Show time until expiration
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

Patchset:

PS2: 
Doesn't look right.  See:
https://pastebin.com/yTcNDHNY

You could append the expired time to the status so it becomes "Registered/exp: 2s".
You also need to fix the header spacing and extend the "===" separator.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17789
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic4fea15a1a1056c424416def49d1ca8e776c0483
Gerrit-Change-Number: 17789
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Mon, 31 Jan 2022 12:30:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220131/08c93bea/attachment.html>


More information about the asterisk-code-review mailing list