[Asterisk-code-review] chan_pjsip.c, chan_sip.c: do not change 180 to 183 (asterisk[16])

[Joshua Colp]

Attention is currently required from: N A, Alexei Gradinari, Mark Petersen.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17785 )

Change subject: chan_pjsip.c, chan_sip.c: do not change 180 to 183
......................................................................


Patch Set 5:

(1 comment)

File channels/chan_pjsip.c:

https://gerrit.asterisk.org/c/asterisk/+/17785/comment/76444671_8871825d 
PS5, Line 1625: 				response_code = 183;
> so how do I proceed from here ? […]
A new option is fine but there is also the inband_progress option, so it has to be clearly documented and stated the interaction between the two. I also don't like that option name, I think it should be an option such as "180_ringing_with_sdp" that enables support for that.

We are also not accepting new features for chan_sip. The chan_sip module should be left alone as much as possible.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17785
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I8a53f8c35595b6d16d8e86e241b5f110d92f3d18
Gerrit-Change-Number: 17785
Gerrit-PatchSet: 5
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Attention: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Comment-Date: Fri, 21 Jan 2022 14:33:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220121/b68c8251/attachment-0001.html>