[Asterisk-code-review] chan_pjsip.c, chan_sip.c: do not change 180 to 183 (asterisk[16])

[Mark Petersen]

Attention is currently required from: Joshua Colp, N A, Alexei Gradinari.
Mark Petersen has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17785 )

Change subject: chan_pjsip.c, chan_sip.c: do not change 180 to 183
......................................................................


Patch Set 5:

(2 comments)

Patchset:

PS4: 
> OK. […]
Ack


File channels/chan_pjsip.c:

https://gerrit.asterisk.org/c/asterisk/+/17785/comment/8159d0c0_43b3b2a9 
PS5, Line 1625: 				response_code = 183;
> The existing behavior has been in place for 20+ years. […]
so how do I proceed from here ?
I do not mind creating it as an config option
I suggest that default for 16,18,19 is "no" and for master is "yes"

16,18,19
;change_180_with_sdp_to_183=no ; enabled this option if caller do not support 180 with SDP, disable this option to be RFC compliant, default value is "yes".

master
;change_180_with_sdp_to_183=yes ; enabled this option if caller do not support 180 with SDP, or to have same behavior as older asterisk, default value is "no".



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17785
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I8a53f8c35595b6d16d8e86e241b5f110d92f3d18
Gerrit-Change-Number: 17785
Gerrit-PatchSet: 5
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Comment-Date: Fri, 21 Jan 2022 14:22:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Alexei Gradinari <alex2grad at gmail.com>
Comment-In-Reply-To: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220121/a6ffea2d/attachment.html>