[Asterisk-code-review] pbx: Ensure we don't operate on dialplan while dialplan is reloading, ... (asterisk[18])

[Joshua Colp]

Attention is currently required from: Sean Bright, Mark Murawski.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17798 )

Change subject: pbx: Ensure we don't operate on dialplan while dialplan is reloading, which causes deadlocks
......................................................................


Patch Set 4: Code-Review-1

(4 comments)

File include/asterisk/module.h:

https://gerrit.asterisk.org/c/asterisk/+/17798/comment/b735e768_20b4defd 
PS4, Line 181: enum ast_module_reload_result ast_module_reload_pending_check(void);
This needs to be documented.


File include/asterisk/pbx.h:

https://gerrit.asterisk.org/c/asterisk/+/17798/comment/dd144f5b_8dbd36f4 
PS4, Line 1072:  * \brief Try and get a read lock the context list
on the context list


File main/loader.c:

https://gerrit.asterisk.org/c/asterisk/+/17798/comment/fd9726f6_25bfe99e 
PS4, Line 1571: 		ast_verb(3, "The previous reload command didn't finish yet\n");
This is an API call to check something, by itself it should not generate a verbose message. The caller should.


File pbx/pbx_config.c:

https://gerrit.asterisk.org/c/asterisk/+/17798/comment/41db279b_b0333c2d 
PS4, Line 1103:         if (ast_module_reload_pending_check() == AST_MODULE_RELOAD_IN_PROGRESS) {
This suffers from a race condition. The dialplan reload could start after this check is done.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17798
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I435db97fc56f18b6f5c25a3e400603817b07aa49
Gerrit-Change-Number: 17798
Gerrit-PatchSet: 4
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Mark Murawski <markm at intellasoft.net>
Gerrit-Comment-Date: Mon, 17 Jan 2022 21:17:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220117/24bf0c18/attachment.html>