[Asterisk-code-review] pbx: Ensure we don't operate on dialplan while dialplan is reloading, ... (asterisk[18])

[Mark Murawski]

Attention is currently required from: Sean Bright.
Mark Murawski has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17798 )

Change subject: pbx: Ensure we don't operate on dialplan while dialplan is reloading, which causes deadlocks
......................................................................


Patch Set 4:

(1 comment)

Patchset:

PS4: 
> This feels very clunky to me. Also the leading whitespace of your changes is all over the place.
It's definitely a quick, but solid fix.

I don't see any legitimate reason that 'dialplan reload' should continually lock up dialplan and reload asterisk.  There is also an easily trigger-able deadlock that needs to be fixed and gracefully bailing from reloads and adds while dialplan is reloading makes I think makes a lot of sense.

If you're reloading dialplan, all bets are off in terms of any dynamically run-time added dialplan sticking around anyway.  Best-case would be to queue up the 'dialplan add' to run after 'dialplan reload' finishes?

What would your preferred approach be?  

Apologies on the whitespace... I haven't yet told emacs to enforce tabs, so it's all by hand.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17798
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I435db97fc56f18b6f5c25a3e400603817b07aa49
Gerrit-Change-Number: 17798
Gerrit-PatchSet: 4
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Mon, 17 Jan 2022 20:53:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220117/fadcadc5/attachment-0001.html>