[Asterisk-code-review] time: add support for time64 libcs (asterisk[master])

[Kevin Harwell]

Attention is currently required from: Joshua Colp, George Joseph, Sebastian Kemper.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16621 )

Change subject: time: add support for time64 libcs
......................................................................


Patch Set 4:

(1 comment)

Patchset:

PS4: 
There are currently two patches up for review regarding this issue. This one here, and https://gerrit.asterisk.org/c/asterisk/+/18013

The patch on the other review is essentially what was originally proposed here in this review (see patches 1-3). However, the issue of compiler portability regarding PRIdN elicited patch 4 here. Apparently some compilers don't implement the macros despite being part of the C99 standard.

To move this issue forward I think we need to decide if we care about PRIdN portability across compilers. I'm all for portability, but I think right now my personal opinion is unless it can be shown that a mainstream compiler (do we care outside of gcc?) does not support the macros then I prefer using the PRIdN macros to fix this issue. It's standardized, and it makes the code cleaner and easier to read.

Also, we use PRIdN elsewhere in the code. If we choose "full" portability then an issue needs to be created to update those other places as well.

What are other's thoughts?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16621
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic8d61b26033f5c486b917e738c9608b0923a844e
Gerrit-Change-Number: 16621
Gerrit-PatchSet: 4
Gerrit-Owner: Sebastian Kemper <sebastian_ml at gmx.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Sebastian Kemper <sebastian_ml at gmx.net>
Gerrit-Comment-Date: Fri, 25 Feb 2022 19:58:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220225/d240e528/attachment-0001.html>