[Asterisk-code-review] res_pjsip_pubsub: update RLS to reflect the changes to the lists (asterisk[16])

[Kevin Harwell]

Attention is currently required from: Alexei Gradinari.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18007 )

Change subject: res_pjsip_pubsub: update RLS to reflect the changes to the lists
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

Patchset:

PS2: 
-1 to remember to update this patch after other one merges


File res/res_pjsip_pubsub.c:

https://gerrit.asterisk.org/c/asterisk/+/18007/comment/b732e818_8707c50a 
PS2, Line 3955: 			/* display_name is added in ASTERISK-29891, uncomment it when ASTERISK-29891 be merged
              : 			|| cmp_strings(c1->display_name, c2->display_name)*/) {
The other patch should hopefully merge soon, so adding this comment so it's not forgotten about.

For future reference if you have a patch that depends upon another patch you can either:

1) Locally, and on the same branch add two commits (one for each patch), and submit them together. You'll get a warning about it from "git review" but if you say "yes" then it'll create two separate reviews here in gerrit with the second patch based off the first.

2) Submit both patches separately, and then in the gerrit UI for the second/dependent patch click "rebase", "Rebase on a specific change, ref, or commit", enter the commit of patch 1, and then click "rebase". Jenkins should then compile things correctly.

Both have their drawbacks though. For example, if you update patch 1 then you usually have to rebase patch 2 which may clear +1's on it.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18007
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Icee8c00459a7aaa43c643d77ce6f16fb7ab037d3
Gerrit-Change-Number: 18007
Gerrit-PatchSet: 2
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Comment-Date: Wed, 23 Feb 2022 18:21:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220223/a5fae4b6/attachment.html>