<p> Attention is currently required from: Alexei Gradinari. </p>
<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/18007">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18007?tab=comments">Patch Set #2:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">-1 to remember to update this patch after other one merges</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_pjsip_pubsub.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18007/comment/b732e818_8707c50a">Patch Set #2, Line 3955:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> /* display_name is added in ASTERISK-29891, uncomment it when ASTERISK-29891 be merged<br> || cmp_strings(c1->display_name, c2->display_name)*/) {<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">The other patch should hopefully merge soon, so adding this comment so it's not forgotten about.</p><p style="white-space: pre-wrap; word-wrap: break-word;">For future reference if you have a patch that depends upon another patch you can either:</p><p style="white-space: pre-wrap; word-wrap: break-word;">1) Locally, and on the same branch add two commits (one for each patch), and submit them together. You'll get a warning about it from "git review" but if you say "yes" then it'll create two separate reviews here in gerrit with the second patch based off the first.</p><p style="white-space: pre-wrap; word-wrap: break-word;">2) Submit both patches separately, and then in the gerrit UI for the second/dependent patch click "rebase", "Rebase on a specific change, ref, or commit", enter the commit of patch 1, and then click "rebase". Jenkins should then compile things correctly.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Both have their drawbacks though. For example, if you update patch 1 then you usually have to rebase patch 2 which may clear +1's on it.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18007">change 18007</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18007"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: Icee8c00459a7aaa43c643d77ce6f16fb7ab037d3 </div>
<div style="display:none"> Gerrit-Change-Number: 18007 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Attention: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 23 Feb 2022 18:21:03 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>