[Asterisk-code-review] app_voicemail: Emit warning if asking for nonexistent mailbox. (asterisk[master])

Sean Bright asteriskteam at digium.com
Wed Feb 16 12:37:57 CST 2022


Attention is currently required from: N A.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18016 )

Change subject: app_voicemail: Emit warning if asking for nonexistent mailbox.
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS1: 
> it's the inconsistent approach to individual reviews that I'm noticing that's unclear to me.

I apologize that you are having inconsistent review experiences. I generally try to minimize the surface area of a change to make it easier for people to review. I feel like that is in line with the spirit of the coding guidelines. If you feel strongly about adding the braces, I will not ding you on it in this review again.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18016
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ib4093b88cd661a2cabc5d685777d4e2f0ebd20a4
Gerrit-Change-Number: 18016
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Wed, 16 Feb 2022 18:37:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220216/9b1539cb/attachment.html>


More information about the asterisk-code-review mailing list