[Asterisk-code-review] app_voicemail: Emit warning if asking for nonexistent mailbox. (asterisk[master])

[N A]

Attention is currently required from: Sean Bright.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18016 )

Change subject: app_voicemail: Emit warning if asking for nonexistent mailbox.
......................................................................


Patch Set 3:

(4 comments)

Patchset:

PS1: 
> > I guess I'm getting mixed messages here. […]
Thanks - your comments themselves are clear, it's the inconsistent approach to individual reviews that I'm noticing that's unclear to me.


File apps/app_voicemail.c:

https://gerrit.asterisk.org/c/asterisk/+/18016/comment/1afc34aa_50a49980 
PS2, Line 11506: 
               : 		if ((context = strchr(args.argv0, '@'))) {
               : 			*context++ = '\0';
               : 		}
               : 
               : 		if (ast_test_flag(&flags, OPT_PREPEND_MAILBOX)) {
               : 			ast_copy_string(prefixstr, args.argv0, sizeof(prefixstr));
               : 		} else {
               : 			ast_copy_string(vms.username, args.argv0, sizeof(vms.username));
               : 		}
> Don't touch these lines.
Done


https://gerrit.asterisk.org/c/asterisk/+/18016/comment/7a5b8d8a_ba28f867 
PS2, Line 11517: 		if (!ast_strlen_zero(vms.username)) {
               : 			if ((vmu = find_user(&vmus, context ,vms.username))) {
               : 				skipuser++;
               : 			} else {
               : 				ast_log(LOG_WARNING, "Mailbox '%s%s%s' doesn't exist\n", vms.username, context ? "@": "", context ? context : "");
               : 				valid = 0;
               : 			}
               : 		} else {
               : 			valid = 0;
               : 		}
> These lines are fine.
Done


https://gerrit.asterisk.org/c/asterisk/+/18016/comment/271ba437_f38159d3 
PS2, Line 11529: if (!valid) {
               : 		res = vm_authenticate(chan, vms.username, sizeof(vms.username), &vmus, context, prefixstr, skipuser, maxlogins, 0);
               : 	}
> Don't touch these lines.
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18016
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ib4093b88cd661a2cabc5d685777d4e2f0ebd20a4
Gerrit-Change-Number: 18016
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Wed, 16 Feb 2022 18:08:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220216/90ca9787/attachment.html>