[Asterisk-code-review] app_voicemail: Emit warning if asking for nonexistent mailbox. (asterisk[master])

[Sean Bright]

Attention is currently required from: N A.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18016 )

Change subject: app_voicemail: Emit warning if asking for nonexistent mailbox.
......................................................................


Patch Set 2: Code-Review-1

(4 comments)

Patchset:

PS1: 
> I guess I'm getting mixed messages here.

Understood. I've added comments to explicitly tell you what I mean. If something isn't clear let me know.


File apps/app_voicemail.c:

https://gerrit.asterisk.org/c/asterisk/+/18016/comment/6b2519e4_aa7fb951 
PS2, Line 11506: 
               : 		if ((context = strchr(args.argv0, '@'))) {
               : 			*context++ = '\0';
               : 		}
               : 
               : 		if (ast_test_flag(&flags, OPT_PREPEND_MAILBOX)) {
               : 			ast_copy_string(prefixstr, args.argv0, sizeof(prefixstr));
               : 		} else {
               : 			ast_copy_string(vms.username, args.argv0, sizeof(vms.username));
               : 		}
Don't touch these lines.


https://gerrit.asterisk.org/c/asterisk/+/18016/comment/45aa8b92_0a00b13c 
PS2, Line 11517: 		if (!ast_strlen_zero(vms.username)) {
               : 			if ((vmu = find_user(&vmus, context ,vms.username))) {
               : 				skipuser++;
               : 			} else {
               : 				ast_log(LOG_WARNING, "Mailbox '%s%s%s' doesn't exist\n", vms.username, context ? "@": "", context ? context : "");
               : 				valid = 0;
               : 			}
               : 		} else {
               : 			valid = 0;
               : 		}
These lines are fine.


https://gerrit.asterisk.org/c/asterisk/+/18016/comment/ef33a43d_e8f6aa40 
PS2, Line 11529: if (!valid) {
               : 		res = vm_authenticate(chan, vms.username, sizeof(vms.username), &vmus, context, prefixstr, skipuser, maxlogins, 0);
               : 	}
Don't touch these lines.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18016
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ib4093b88cd661a2cabc5d685777d4e2f0ebd20a4
Gerrit-Change-Number: 18016
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Wed, 16 Feb 2022 17:29:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220216/76927deb/attachment.html>