[Asterisk-code-review] app_voicemail: Emit warning if asking for nonexistent mailbox. (asterisk[master])

[N A]

Attention is currently required from: Sean Bright.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18016 )

Change subject: app_voicemail: Emit warning if asking for nonexistent mailbox.
......................................................................


Patch Set 2:

(2 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/18016/comment/0b4233e1_aa3706ad 
PS1, Line 7: Throw 
> 'Emit' or 'Log' instead of 'Throw. […]
Done


Patchset:

PS1: 
> Don't mix functional and non-functional changes in a single review. […]
I guess I'm getting mixed messages here. In the past, I did that, and then I'd get told "While you're here, clean this up..." (by multiple people). I had to add some braces for the expanded else as it was, so I anticipated being asked to do this and just added the braces from the get go.

Whether reviews should be strictly focused on the change or hand or be able to "clean up minor things" in that area might be worth clarifying on the coding guidelines, as it's not consistent right now.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18016
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ib4093b88cd661a2cabc5d685777d4e2f0ebd20a4
Gerrit-Change-Number: 18016
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Wed, 16 Feb 2022 17:22:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220216/d9813798/attachment.html>