[Asterisk-code-review] geolocation: Add sample config file (asterisk[development/16/geolocation])

[George Joseph]

Attention is currently required from: N A, Joshua Colp, Kevin Harwell.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18015 )

Change subject: geolocation:  Add sample config file
......................................................................


Patch Set 1:

(2 comments)

File configs/samples/geolocation.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/18015/comment/05a30f64_d146881a 
PS1, Line 17:   - Location information specified in Geographic Markup Langiage (GML),
> Apologies if someone else caught this already, but "Langiage" is misspelled.

There had to be something misspelled or it wouldn't be one of my reviews. 😊
Thanks.


https://gerrit.asterisk.org/c/asterisk/+/18015/comment/a49880b2_d27088b3 
PS1, Line 122: ;-- location ---------------------------------------
             : 
             : The actual location information to send.  The format depends on the
             : "format" parameter set above.  For readability, multiple "location"
             : parameters can be specified and they will be concatenated into one
             : specification.
> Looks like a particular location can be used for multiple profiles. I wonder if it would make more sense to make them their own typed section in sorcery. Especially since each location is also associated with a number of name/value parameters depending on the type of location.
> 
> Thoughts?

That's why I mentioned templates in the examples below.  Templates aren't supported by realtime though so having a separate type might be OK.  I'd have to work something up so you can reference a location in a profile but then append info to it.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18015
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: development/16/geolocation
Gerrit-Change-Id: Ieb809ed5f843c64528f00a3f08493f24cf4f0ee5
Gerrit-Change-Number: 18015
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 16 Feb 2022 16:41:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220216/152facdf/attachment-0001.html>