[Asterisk-code-review] geolocation: Add sample config file (asterisk[development/16/geolocation])

George Joseph asteriskteam at digium.com
Wed Feb 16 10:37:18 CST 2022


Attention is currently required from: Joshua Colp.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18015 )

Change subject: geolocation:  Add sample config file
......................................................................


Patch Set 1:

(5 comments)

File configs/samples/geolocation.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/18015/comment/a416c7ba_12e32675 
PS1, Line 17:   - Location information specified in Geographic Markup Langiage (GML),
> Specify this is optional.
Done


https://gerrit.asterisk.org/c/asterisk/+/18015/comment/9b2a51a8_31f80b49 
PS1, Line 20:   - URIs that point to externally hosted location information.
> Specify this is optional.
Done


https://gerrit.asterisk.org/c/asterisk/+/18015/comment/7d93fbac_609cac2f 
PS1, Line 28: UAC).
> I'd expand this further, "to control behavior in each direction and to optionally specify location i […]
Done


https://gerrit.asterisk.org/c/asterisk/+/18015/comment/e33579e8_5365bc2d 
PS1, Line 37: Must be "profile" to identify this configuration section as a location
> Since this configuration doesn't actually require location information (for example in the case of h […]
Done


https://gerrit.asterisk.org/c/asterisk/+/18015/comment/b308e6e8_5aa459a0 
PS1, Line 67: which the location information will be placed.
> Should we document that if communicating with an upstream provider, to talk to them in regards to wh […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18015
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: development/16/geolocation
Gerrit-Change-Id: Ieb809ed5f843c64528f00a3f08493f24cf4f0ee5
Gerrit-Change-Number: 18015
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 16 Feb 2022 16:37:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220216/1c3fb742/attachment.html>


More information about the asterisk-code-review mailing list