[Asterisk-code-review] file.c: ast_fileexists filename is empty or NULL (asterisk[16])

N A asteriskteam at digium.com
Sun Feb 13 05:09:25 CST 2022


Attention is currently required from: Mark Petersen.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18011 )

Change subject: file.c: ast_fileexists filename is empty or NULL
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

File main/file.c:

https://gerrit.asterisk.org/c/asterisk/+/18011/comment/24ed77fd_0cb189a0 
PS2, Line 1106: 	if(ast_strlen_zero(filename))
Put a space between the if and the (.
Additionally, braces are needed around single if statements, per the coding guidelines: https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18011
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ic1617fec118e8497c3a0ff8675a572f75cff34c0
Gerrit-Change-Number: 18011
Gerrit-PatchSet: 2
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-CC: Mark Petersen <asterisk.org at zombie.dk>
Gerrit-Attention: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Comment-Date: Sun, 13 Feb 2022 11:09:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220213/f7938f20/attachment-0001.html>


More information about the asterisk-code-review mailing list