[Asterisk-code-review] file.c: ast_fileexists filename is empty or NULL (asterisk[16])

Mark Petersen asteriskteam at digium.com
Sun Feb 13 01:40:45 CST 2022


Attention is currently required from: N A, Mark Petersen.
Mark Petersen has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18011 )

Change subject: file.c: ast_fileexists filename is empty or NULL
......................................................................


Patch Set 2:

(1 comment)

File main/file.c:

https://gerrit.asterisk.org/c/asterisk/+/18011/comment/25b803c4_e055a6b4 
PS1, Line 1106: 	if(filename == NULL || strlen(filename) == 0)
> Any particular reason not to use the ast_strlen_zero macro?
no, just my original patch was 10 year old



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18011
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ic1617fec118e8497c3a0ff8675a572f75cff34c0
Gerrit-Change-Number: 18011
Gerrit-PatchSet: 2
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Mark Petersen <asterisk.org at zombie.dk>
Gerrit-CC: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Comment-Date: Sun, 13 Feb 2022 07:40:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220213/cd27cf98/attachment.html>


More information about the asterisk-code-review mailing list