[Asterisk-code-review] time: add support for time64 libcs (asterisk[master])

[Sebastian Kemper]

Attention is currently required from: Joshua Colp, George Joseph, Philip Prindeville.
Sebastian Kemper has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16621 )

Change subject: time: add support for time64 libcs
......................................................................


Patch Set 4:

(3 comments)

File res/res_calendar_icalendar.c:

https://gerrit.asterisk.org/c/asterisk/+/16621/comment/81600d51_00a299e4 
PS4, Line 248: 			char tmp[100];
> Maybe I'm missing something, but ULLONG_MAX is 20 digits long, and then one more char for the NUL wo […]
I don't see how this is related to my patch.


File res/res_http_media_cache.c:

https://gerrit.asterisk.org/c/asterisk/+/16621/comment/8a912a76_971b69f9 
PS4, Line 304: 	long long llv;
> This isn't necessary.
It is, see [1].

[1] https://stackoverflow.com/questions/4171478/how-to-read-data-into-a-time-t-variable-using-scanf


https://gerrit.asterisk.org/c/asterisk/+/16621/comment/f099b8d5_afbeebf2 
PS4, Line 314: 	expires.tv_sec = llv;
> And here we're just creating a potential loss-of-precision error when a int64_t gets saved into a in […]
With the patch as is I don't see a possibility of precision loss.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16621
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic8d61b26033f5c486b917e738c9608b0923a844e
Gerrit-Change-Number: 16621
Gerrit-PatchSet: 4
Gerrit-Owner: Sebastian Kemper <sebastian_ml at gmx.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Comment-Date: Sat, 12 Feb 2022 12:05:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220212/4dbc18c9/attachment.html>