[Asterisk-code-review] time: add support for time64 libcs (asterisk[master])

Sebastian Kemper asteriskteam at digium.com
Sat Feb 12 06:00:39 CST 2022


Attention is currently required from: Joshua Colp, George Joseph, Philip Prindeville.
Sebastian Kemper has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16621 )

Change subject: time: add support for time64 libcs
......................................................................


Patch Set 4:

(1 comment)

File include/asterisk/time.h:

https://gerrit.asterisk.org/c/asterisk/+/16621/comment/83c017b3_c07dd576 
PS4, Line 33: #define TIME_T_CAST(x) ((long long)(x))
> In my opinion this is fine. In the worst case this is an integer conversion from 32 bits to 64 bits. […]
Forgot to click Resolved



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16621
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic8d61b26033f5c486b917e738c9608b0923a844e
Gerrit-Change-Number: 16621
Gerrit-PatchSet: 4
Gerrit-Owner: Sebastian Kemper <sebastian_ml at gmx.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Comment-Date: Sat, 12 Feb 2022 12:00:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sebastian Kemper <sebastian_ml at gmx.net>
Comment-In-Reply-To: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220212/cb3e5434/attachment.html>


More information about the asterisk-code-review mailing list