[Asterisk-code-review] res_pjsip_logger.c: Don't blindly disable logging on res_pjsip reload. (asterisk[16])

[Kevin Harwell]

Attention is currently required from: Sean Bright.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18010 )

Change subject: res_pjsip_logger.c: Don't blindly disable logging on res_pjsip reload.
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

Patchset:

PS2: 
On one hand, I feel like this fix makes it so a reload may not fully reflect the current configuration state. On the other hand, in some cases it makes sense that a CLI command may override things even when a reload occurs.

I've actually run into this myself with pjsip logging and wondered why it stopped, and then realized I had reloaded and it had been disabled.

I think in a logging case, especially for debug this is acceptable and maybe even expected. My two cents not than anyone asked :-)



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18010
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I3c9e6f39da65a625d8295178b526ed2cce4be115
Gerrit-Change-Number: 18010
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Bright <sean at seanbright.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Fri, 11 Feb 2022 17:24:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220211/f9e8d995/attachment.html>