[Asterisk-code-review] res_pjsip_logger.c: Don't blindly disable logging on res_pjsip reload. (asterisk[16])

Sean Bright asteriskteam at digium.com
Fri Feb 11 10:10:09 CST 2022


Attention is currently required from: Sean Bright.
Hello Joshua Colp, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/18010

to look at the new patch set (#2).

Change subject: res_pjsip_logger.c: Don't blindly disable logging on res_pjsip reload.
......................................................................

res_pjsip_logger.c: Don't blindly disable logging on res_pjsip reload.

When res_pjsip is reloaded, the logger module will look at the 'debug'
option under a type=global PJSIP section and react
appropriately. Unfortunately, because 'debug' defaults to 'no',
issuing a reload will disable all logging even if you haven't
explicitly asked for it to be disabled.

Now we check that the value of the 'debug' option has changed between
reload invocations and only react when it has.

ASTERISK-29912 #close

Change-Id: I3c9e6f39da65a625d8295178b526ed2cce4be115
---
A doc/CHANGES-staging/res_pjsip_logger_reload.txt
M res/res_pjsip_logger.c
2 files changed, 23 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/10/18010/2
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18010
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I3c9e6f39da65a625d8295178b526ed2cce4be115
Gerrit-Change-Number: 18010
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Bright <sean at seanbright.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220211/75d4d1ed/attachment.html>


More information about the asterisk-code-review mailing list