[Asterisk-code-review] cli: Add command to evaluate dialplan functions. (asterisk[master])

Joshua Colp asteriskteam at digium.com
Wed Feb 2 12:00:38 CST 2022


Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17714 )

Change subject: cli: Add command to evaluate dialplan functions.
......................................................................


Patch Set 5:

(1 comment)

File main/pbx_variables.c:

https://gerrit.asterisk.org/c/asterisk/+/17714/comment/7402ac96_85f5c8aa 
PS5, Line 965: 	ast_cli(a->fd, "Retval: %d\n", ret);
> Would "Return Value" be fine, or are you saying something more human friendly along the lines of "Su […]
I think "Return Value" with "Success (0)" and such is fine.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17714
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I833e97ea54c49336aca145330a2adeebfad05209
Gerrit-Change-Number: 17714
Gerrit-PatchSet: 5
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Wed, 02 Feb 2022 18:00:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220202/12a22f1f/attachment.html>


More information about the asterisk-code-review mailing list