[Asterisk-code-review] cli: Add command to evaluate dialplan functions. (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17714 )

Change subject: cli: Add command to evaluate dialplan functions.
......................................................................


Patch Set 5:

(1 comment)

File main/pbx_variables.c:

https://gerrit.asterisk.org/c/asterisk/+/17714/comment/33146c21_548a5bfd 
PS5, Line 965: 	ast_cli(a->fd, "Retval: %d\n", ret);
> As a user I don't think they'd understand what "Retval" means, or really have any understanding of t […]
Would "Return Value" be fine, or are you saying something more human friendly along the lines of "Success" and "Failure" instead of 0 and -1?

Would Success (0) and Failure (-1 or non-zero) be fine?
I'm not sure if functions ever return anything besides 0 or -1, but if they did, it would be helpful to see the actual return value.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17714
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I833e97ea54c49336aca145330a2adeebfad05209
Gerrit-Change-Number: 17714
Gerrit-PatchSet: 5
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 02 Feb 2022 17:53:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220202/a4092f76/attachment-0001.html>