[Asterisk-code-review] res_prometheus.c: missing module dependency (asterisk[18])

[Joshua Colp]

Attention is currently required from: N A, Mark Petersen, Kevin Harwell.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17913 )

Change subject: res_prometheus.c: missing module dependency
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

File res/res_prometheus.c:

https://gerrit.asterisk.org/c/asterisk/+/17913/comment/d7a9b91c_d65fcc4e 
PS3, Line 1005: 	.requires = "res_pjsip,res_pjsip_outbound_registration",
> any suggestion to where and what to comment in the code would be appreciated […]
I'd leave it. And a code comment would be something like:

"This module explicitly calls into res_pjsip if Asterisk is built with PJSIP support, so they are required."



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17913
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ia0f49d048427a40e1b763296b834a52a03610096
Gerrit-Change-Number: 17913
Gerrit-PatchSet: 6
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 02 Feb 2022 17:14:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Mark Petersen <bugs.digium.com at zombie.dk>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220202/a03ad243/attachment-0001.html>