[Asterisk-code-review] res_prometheus.c: missing module dependency (asterisk[18])

[Mark Petersen]

Attention is currently required from: Joshua Colp, N A, Kevin Harwell.
Mark Petersen has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17913 )

Change subject: res_prometheus.c: missing module dependency
......................................................................


Patch Set 6:

(1 comment)

File res/res_prometheus.c:

https://gerrit.asterisk.org/c/asterisk/+/17913/comment/3e00d98a_a3df9ea3 
PS3, Line 1005: 	.requires = "res_pjsip,res_pjsip_outbound_registration",
> So looking at the code, it's all because of res/prometheus/pjsip_outbound_registrations. […]
any suggestion to where and what to comment in the code would be appreciated

also should I remove "res_pjsip" as you are forced to include it in order to use "res_pjsip_outbound_registration"



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17913
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ia0f49d048427a40e1b763296b834a52a03610096
Gerrit-Change-Number: 17913
Gerrit-PatchSet: 6
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 01 Feb 2022 21:34:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Mark Petersen <bugs.digium.com at zombie.dk>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220201/44995d66/attachment.html>