[Asterisk-code-review] res_http_media_cache: Introduce options and customize (asterisk[20])

[Joshua Colp]

Attention is currently required from: Sean Bright, Holger Hans Peter Freyther.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19658 )

Change subject: res_http_media_cache: Introduce options and customize
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

File res/res_http_media_cache.c:

https://gerrit.asterisk.org/c/asterisk/+/19658/comment/d8246da2_3fa5d09f 
PS5, Line 734: #ifdef AST_CURL_HAS_PROTOCOLS_STR
> Changed. […]
The philosophy of sorcery and config options is that in most cases an invalid configuration (which in my opinion this is) should result in failure, otherwise it can be hidden and what the user intended to happen may not happen. I think it should decline to load instead.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19658
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 20
Gerrit-Change-Id: I2eb02ef44190e026716720419bcbdbcc8125777b
Gerrit-Change-Number: 19658
Gerrit-PatchSet: 6
Gerrit-Owner: Holger Hans Peter Freyther <automatic at freyther.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Holger Hans Peter Freyther <automatic at freyther.de>
Gerrit-Comment-Date: Tue, 27 Dec 2022 14:34:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Holger Hans Peter Freyther <automatic at freyther.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221227/2590f98b/attachment-0001.html>