[Asterisk-code-review] res_http_media_cache: Introduce options and customize (asterisk[20])

[Holger Hans Peter Freyther]

Attention is currently required from: Sean Bright, Joshua Colp.

Holger Hans Peter Freyther has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19658 )

Change subject: res_http_media_cache: Introduce options and customize
......................................................................


Patch Set 6:

(1 comment)

File res/res_http_media_cache.c:

https://gerrit.asterisk.org/c/asterisk/+/19658/comment/5e4ee0e7_2dfb8051 
PS5, Line 734: #ifdef AST_CURL_HAS_PROTOCOLS_STR
> Configuration options shouldn't be ifdeffed out like this. […]
Changed. The check will now result into the ACO_PROCESS_ERROR and the code will fall-back to load the defaults. Is that behavior okay, e.g. over declining to load?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19658
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 20
Gerrit-Change-Id: I2eb02ef44190e026716720419bcbdbcc8125777b
Gerrit-Change-Number: 19658
Gerrit-PatchSet: 6
Gerrit-Owner: Holger Hans Peter Freyther <automatic at freyther.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 23 Dec 2022 13:53:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221223/1280a16c/attachment-0001.html>