[Asterisk-code-review] res_monitor: Remove deprecated module. (asterisk[master])

[N A]

Attention is currently required from: Michael Bradeen.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19605 )

Change subject: res_monitor: Remove deprecated module.
......................................................................


Patch Set 3: Code-Review-1

(6 comments)

Patchset:

PS3: 
I presume since it should all be automixmon now, these references to automon can be removed as well?

main/bridge_basic.c:    res |= builtin_features_helper(features, chan, flags, AST_FEATURE_AUTOMON, "automon", AST_BRIDGE_BUILTIN_AUTOMON);
include/asterisk/features_config.h:             /*! Sound played when automon or automixmon features are used */
include/asterisk/features_config.h:             /*! Sound played when automon or automixmon features fail when used */
include/asterisk/features_config.h:             AST_STRING_FIELD(automon);


File bridges/bridge_builtin_features.c:

https://gerrit.asterisk.org/c/asterisk/+/19605/comment/81e85ab0_bf51cb1d 
PS3, Line 92: 	}
Since the else was always res_monitor stuff, isn't "is_mixmonitor" always true here now?


File configs/samples/queues.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/19605/comment/dca64272_04fd7cc4 
PS3, Line 31: ;    monitor-type = MixMonitor is the only currently supported ption.
option


https://gerrit.asterisk.org/c/asterisk/+/19605/comment/a222ea84_6aebcb1e 
PS3, Line 32: ;    The concept of "joining/mixing" the in/out files now goes away.
I think the 2nd sentence could maybe use a bit more context, now that the other stuff has been removed. How about "MixMonitor automatically mixes audio by default, so it is generally not necessary to join/mix in and out files."


https://gerrit.asterisk.org/c/asterisk/+/19605/comment/6661b5a3_c8e93547 
PS3, Line 388: ;    monitor-type = MixMonitor is the only currently supported ption.
option, and same comments as above


File configs/samples/sip.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/19605/comment/94e56393_ca75d2e5 
PS3, Line 158:  
option should be singular here and below



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19605
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I0462caefb4f9544e2e2baa23c498858310b52d50
Gerrit-Change-Number: 19605
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Comment-Date: Fri, 23 Dec 2022 19:03:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221223/0ac49bb0/attachment.html>