<p> Attention is currently required from: Michael Bradeen. </p>
<p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/19605">View Change</a></p><p>6 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19605?tab=comments">Patch Set #3:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">I presume since it should all be automixmon now, these references to automon can be removed as well?</p><p style="white-space: pre-wrap; word-wrap: break-word;">main/bridge_basic.c:    res |= builtin_features_helper(features, chan, flags, AST_FEATURE_AUTOMON, "automon", AST_BRIDGE_BUILTIN_AUTOMON);<br>include/asterisk/features_config.h:             /*! Sound played when automon or automixmon features are used */<br>include/asterisk/features_config.h:             /*! Sound played when automon or automixmon features fail when used */<br>include/asterisk/features_config.h:             AST_STRING_FIELD(automon);</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File bridges/bridge_builtin_features.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19605/comment/81e85ab0_bf51cb1d">Patch Set #3, Line 92:</a> <code style="font-family:monospace,monospace">      }</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Since the else was always res_monitor stuff, isn't "is_mixmonitor" always true here now?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File configs/samples/queues.conf.sample:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19605/comment/dca64272_04fd7cc4">Patch Set #3, Line 31:</a> <code style="font-family:monospace,monospace">;    monitor-type = MixMonitor is the only currently supported ption.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">option</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19605/comment/a222ea84_6aebcb1e">Patch Set #3, Line 32:</a> <code style="font-family:monospace,monospace">;    The concept of "joining/mixing" the in/out files now goes away.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think the 2nd sentence could maybe use a bit more context, now that the other stuff has been removed. How about "MixMonitor automatically mixes audio by default, so it is generally not necessary to join/mix in and out files."</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19605/comment/6661b5a3_c8e93547">Patch Set #3, Line 388:</a> <code style="font-family:monospace,monospace">;    monitor-type = MixMonitor is the only currently supported ption.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">option, and same comments as above</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File configs/samples/sip.conf.sample:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19605/comment/94e56393_ca75d2e5">Patch Set #3, Line 158:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">option should be singular here and below</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/19605">change 19605</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/19605"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0462caefb4f9544e2e2baa23c498858310b52d50 </div>
<div style="display:none"> Gerrit-Change-Number: 19605 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Attention: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 23 Dec 2022 19:03:36 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>