[Asterisk-code-review] res_pjsip_logger: Preserve logging state on reloads. (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19575 )

Change subject: res_pjsip_logger: Preserve logging state on reloads.
......................................................................


Patch Set 1:

(1 comment)

File res/res_pjsip_logger.c:

https://gerrit.asterisk.org/c/asterisk/+/19575/comment/d529a043_05694327 
PS1, Line 671: 		/* If the logger was enabled via the CLI instead of
> Okay, so what is the result of all the different combinations and scenarios? If this is being change […]
if debug=no:
reload: stays off
CLI disable: stays off
CLI enable: turns on
CLI enable, then reload: stays on
CLI disable, then reload: stays off
CLI disable: turns off

if debug=yes:
reload: stays on
CLI enable: stays on
CLI disable: stays off
CLI enable, then reload: stays on
CLI disable, then reload: turns on again. Maybe should stay off?

In the latter case, an option is to keep a flag if logging was explicitly disabled via the CLI (as opposed to explicitly enabled via the config file), and if so, then refuse to process a true config value.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19575
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I0be7d90e7007f5a6bc4a1cb75019fbaeb18428da
Gerrit-Change-Number: 19575
Gerrit-PatchSet: 1
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 22 Dec 2022 12:35:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221222/59bbc1e9/attachment.html>