[Asterisk-code-review] res_pjsip_logger: Preserve logging state on reloads. (asterisk[master])

Joshua Colp asteriskteam at digium.com
Thu Dec 22 06:14:16 CST 2022


Attention is currently required from: N A.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19575 )

Change subject: res_pjsip_logger: Preserve logging state on reloads.
......................................................................


Patch Set 1:

(1 comment)

File res/res_pjsip_logger.c:

https://gerrit.asterisk.org/c/asterisk/+/19575/comment/4128b75c_e7d34610 
PS1, Line 671: 		/* If the logger was enabled via the CLI instead of
> No, it would be enabled when the module loads, but disabled if disabled in the CLI (and just tested  […]
Okay, so what is the result of all the different combinations and scenarios? If this is being changed, then we need to ensure that everyone is on the same page as to how it should all work and behave and that they all make sense.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19575
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I0be7d90e7007f5a6bc4a1cb75019fbaeb18428da
Gerrit-Change-Number: 19575
Gerrit-PatchSet: 1
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Thu, 22 Dec 2022 12:14:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221222/5aac5bb7/attachment-0001.html>


More information about the asterisk-code-review mailing list