[Asterisk-code-review] pbx_dundi: Add PJSIP support. (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19702 )

Change subject: pbx_dundi: Add PJSIP support.
......................................................................


Patch Set 3:

(2 comments)

File configs/samples/dundi.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/19702/comment/f29b3f48_9f0bccea 
PS3, Line 79: ; Name of endpoint from pjsip.conf to use for outgoing calls from this system,
> Thinking about this some more I think control over what SIP channel driver is used should be in the  […]
What do you mean by this exactly, are you saying there should be an option to choose SIP or PJSIP for all SIP/PJSIP calls?
For all other protocols, there's only 1 channel driver, and SIP is going away now, so PJSIP is all that will remain soon as well, so I'm not sure I fully follow.


https://gerrit.asterisk.org/c/asterisk/+/19702/comment/6349ab75_f5e65b8a 
PS3, Line 80: ; when using PJSIP.
> when a DUNDi peer provides a PJSIP based destination.
I guess per your comments it would also be any SIP-based destination?
For example, there might be an old Asterisk system using SIP only without PJSIP. It could hand out SIP endpoints, but newer systems would need to dial those as PJSIP, not SIP.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19702
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I2e28e5a5d007bd49e3df113ad567b011103899bf
Gerrit-Change-Number: 19702
Gerrit-PatchSet: 3
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 22 Dec 2022 12:02:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221222/4ddf5155/attachment.html>