[Asterisk-code-review] pbx_dundi: Add PJSIP support. (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19702 )

Change subject: pbx_dundi: Add PJSIP support.
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

File configs/samples/dundi.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/19702/comment/05cbbb4e_0171f111 
PS3, Line 79: ; Name of endpoint from pjsip.conf to use for outgoing calls from this system,
Thinking about this some more I think control over what SIP channel driver is used should be in the control of the dialling system. The fact it's using PJSIP is a choice of that user, not of a remote DUNDi peer. SIP is SIP and a DUNDi peer just specifies the protocol to use, not the channel driver.


https://gerrit.asterisk.org/c/asterisk/+/19702/comment/ee247128_6c797f16 
PS3, Line 80: ; when using PJSIP.
when a DUNDi peer provides a PJSIP based destination.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19702
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I2e28e5a5d007bd49e3df113ad567b011103899bf
Gerrit-Change-Number: 19702
Gerrit-PatchSet: 3
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Thu, 22 Dec 2022 10:13:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221222/6c19c534/attachment.html>