[Asterisk-code-review] apps/app_queue: Preserve reason for realtime queues (asterisk[18])

Alexei Gradinari asteriskteam at digium.com
Wed Dec 21 09:42:18 CST 2022


Attention is currently required from: N A, Stanislav Abramenkov, Niklas Larsson.

Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19741 )

Change subject: apps/app_queue: Preserve reason for realtime queues
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/19741/comment/84a7b8dd_8ea75c43 
PS4, Line 7754: update_realtime_member_field
1. If DB table doesn't have this field then all updates will produce error.
On loading module need to call ast_realtime_require_field and save result.
Call Update only if the field exists (check ast_realtime_require_field result)

2. If the field "reason_paused" exists need to call Update only ones for both fields: "paused" and "reason_paused".



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19741
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ica08baa5cab6b18105b5d719a183f9fd582fcf09
Gerrit-Change-Number: 19741
Gerrit-PatchSet: 4
Gerrit-Owner: Niklas Larsson <niklas at tese.se>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: Niklas Larsson <niklas at tese.se>
Gerrit-Comment-Date: Wed, 21 Dec 2022 15:42:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221221/129cff6b/attachment.html>


More information about the asterisk-code-review mailing list