[Asterisk-code-review] apps/app_queue: Preserve reason for realtime queues (asterisk[18])

[Niklas Larsson]

Attention is currently required from: N A, Stanislav Abramenkov.

Niklas Larsson has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19741 )

Change subject: apps/app_queue: Preserve reason for realtime queues
......................................................................


Patch Set 4:

(6 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/19741/comment/dbbf8614_9e627980 
PS3, Line 9: When the Asterisk is restared it does not preserve paused reason for
> restarted
Done


https://gerrit.asterisk.org/c/asterisk/+/19741/comment/916baa76_77a8e0ef 
PS3, Line 11: https://gerrit.asterisk.org/c/asterisk/+/2131/
> Reference the issue number like so: ASTERISK_25732
Done


Patchset:

PS4: 
fixed and fixed and fixed - thanks for helping! (and I'm a bit ashamed to miss the simple white-spaces, and spelling).


File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/19741/comment/4d6b75dd_ec209a32 
PS3, Line 3657: 			ast_copy_string(m->reason_paused, (reason_paused ? reason_paused : "\0"), sizeof(m->reason_paused));
> Use S_OR(reason_paused, "")
Done


https://gerrit.asterisk.org/c/asterisk/+/19741/comment/6373ea64_642f8322 
PS3, Line 3672: 			if (!ast_strlen_zero(reason_paused)){
> Missing space between ) and {
Done


https://gerrit.asterisk.org/c/asterisk/+/19741/comment/a57365bb_de45ba53 
PS3, Line 7753: 		if (strcmp(mem->reason_paused, reason ? reason : "\0")){
> Same here, use S_OR
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19741
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ica08baa5cab6b18105b5d719a183f9fd582fcf09
Gerrit-Change-Number: 19741
Gerrit-PatchSet: 4
Gerrit-Owner: Niklas Larsson <niklas at tese.se>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Comment-Date: Wed, 21 Dec 2022 14:19:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221221/b4480abb/attachment-0001.html>