[Asterisk-code-review] chan_sip: Remove deprecated module. (asterisk[master])

[N A]

Attention is currently required from: Michael Bradeen.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19611 )

Change subject: chan_sip: Remove deprecated module.
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

Patchset:

PS2: 
> Also: […]
Sorry, a couple more stragglers:

channels/console_video.c:In order to handle video you need to add to sip.conf (and presumably
contrib/scripts/retrieve_sip_conf_from_mysql.pl:$sip_conf = "/etc/asterisk/sip_additional.conf";
contrib/scripts/retrieve_sip_conf_from_mysql.pl:open EXTEN, ">$sip_conf" || die "Cannot create/overwrite extensions file: $sip_conf\n";
contrib/scripts/sip_nat_settings:# sip_nat_settings: generate NAT settings for sip.conf of an Asterisk system
contrib/scripts/sip_nat_settings:# of sip.conf. The output should be included in the [general] section of
contrib/scripts/sip_nat_settings:# sip.conf .

funcs/func_enum.c:                              <literal>sip</literal>.</para>
funcs/func_enum.c:                                <literal>sip</literal>.</para>
funcs/func_enum.c:              ast_copy_string(tech,"sip",sizeof(tech));
funcs/func_enum.c:      ast_copy_string(tech, args.tech ? args.tech : "sip", sizeof(tech));

With regards to that last one, the default tech should be something other than SIP, I guess PJSIP would make sense, and then the documentation should be updated accordingly.

I *think* that's the last of it that I'm seeing...



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19611
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic700168c80b68879d9cee8bb07afe2712fb17996
Gerrit-Change-Number: 19611
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Comment-Date: Wed, 21 Dec 2022 01:52:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221221/d054c3f9/attachment.html>