<p> Attention is currently required from: Michael Bradeen. </p>
<p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/19611">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19611?tab=comments">Patch Set #2:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Also: […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Sorry, a couple more stragglers:</p><p style="white-space: pre-wrap; word-wrap: break-word;">channels/console_video.c:In order to handle video you need to add to sip.conf (and presumably<br>contrib/scripts/retrieve_sip_conf_from_mysql.pl:$sip_conf = "/etc/asterisk/sip_additional.conf";<br>contrib/scripts/retrieve_sip_conf_from_mysql.pl:open EXTEN, ">$sip_conf" || die "Cannot create/overwrite extensions file: $sip_conf\n";<br>contrib/scripts/sip_nat_settings:# sip_nat_settings: generate NAT settings for sip.conf of an Asterisk system<br>contrib/scripts/sip_nat_settings:# of sip.conf. The output should be included in the [general] section of<br>contrib/scripts/sip_nat_settings:# sip.conf .</p><p style="white-space: pre-wrap; word-wrap: break-word;">funcs/func_enum.c: <literal>sip</literal>.</para><br>funcs/func_enum.c: <literal>sip</literal>.</para><br>funcs/func_enum.c: ast_copy_string(tech,"sip",sizeof(tech));<br>funcs/func_enum.c: ast_copy_string(tech, args.tech ? args.tech : "sip", sizeof(tech));</p><p style="white-space: pre-wrap; word-wrap: break-word;">With regards to that last one, the default tech should be something other than SIP, I guess PJSIP would make sense, and then the documentation should be updated accordingly.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I *think* that's the last of it that I'm seeing...</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/19611">change 19611</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/19611"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic700168c80b68879d9cee8bb07afe2712fb17996 </div>
<div style="display:none"> Gerrit-Change-Number: 19611 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Attention: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 21 Dec 2022 01:52:22 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Comment-In-Reply-To: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>