[Asterisk-code-review] res_http_media_cache: Introduce options and customize (asterisk[20])

[Sean Bright]

Attention is currently required from: Joshua Colp, N A, Holger Hans Peter Freyther.

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19658 )

Change subject: res_http_media_cache: Introduce options and customize
......................................................................


Patch Set 3: Code-Review-1

(5 comments)

Patchset:

PS3: 
I realize you are using the same names that cURL does but there is no reason we can't make them more user friendly in our configs.


File res/res_http_media_cache.c:

https://gerrit.asterisk.org/c/asterisk/+/19658/comment/b08761de_4d74aa48 
PS3, Line 43: 				<configOption name="useragent">
user_agent


https://gerrit.asterisk.org/c/asterisk/+/19658/comment/1994ecd3_4d92d584 
PS3, Line 46: 				<configOption name="followlocation" default="1">
follow_location


https://gerrit.asterisk.org/c/asterisk/+/19658/comment/24a97d15_2d840503 
PS3, Line 49: 				<configOption name="maxredirects" default="8">
max_redirects


https://gerrit.asterisk.org/c/asterisk/+/19658/comment/f5b3577f_be2661be 
PS3, Line 58: 				<configOption name="redir_protocols">
redirect_protocols (or something else more descriptive)



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19658
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 20
Gerrit-Change-Id: I2eb02ef44190e026716720419bcbdbcc8125777b
Gerrit-Change-Number: 19658
Gerrit-PatchSet: 3
Gerrit-Owner: Holger Hans Peter Freyther <automatic at freyther.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Holger Hans Peter Freyther <automatic at freyther.de>
Gerrit-Comment-Date: Thu, 15 Dec 2022 17:20:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221215/05014754/attachment-0001.html>