[Asterisk-code-review] res_http_media_cache: Introduce options and customize (asterisk[20])

[Holger Hans Peter Freyther]

Attention is currently required from: Joshua Colp, N A.

Holger Hans Peter Freyther has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19658 )

Change subject: res_http_media_cache: Introduce options and customize
......................................................................


Patch Set 2:

(5 comments)

Patchset:

PS2: 
Moved to ACO and string fields. The one downside of string_fields is that modeling
a tri-state becomes hard (e.g. proxy not set, proxy disabled by "", proxy set by non-empty string)


File doc/CHANGES-staging/res_http_media_cache.txt:

https://gerrit.asterisk.org/c/asterisk/+/19658/comment/e02b2cfa_f610d0e7 
PS2, Line 3: The res_http_media_cache module now attempts to load
> Once squashed I also think this should include the list of options that are now available.
Done


File res/res_http_media_cache.c:

https://gerrit.asterisk.org/c/asterisk/+/19658/comment/f1abf1a8_17f08c84 
PS1, Line 52: 			</configObject>
> I think they should be squashed.
Done


File res/res_http_media_cache.c:

https://gerrit.asterisk.org/c/asterisk/+/19658/comment/734c7af1_f467ea57 
PS2, Line 49: 				<configOption name="maxrdirects" default="8">
> misrdirects instead of misredirects
Done


https://gerrit.asterisk.org/c/asterisk/+/19658/comment/fd101859_44eaac75 
PS2, Line 580: 	cfg = ast_config_load("res_http_media_cache.conf", config_flags);
> This is the old style of configuration files. […]
Thank you for the pointers.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19658
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 20
Gerrit-Change-Id: I2eb02ef44190e026716720419bcbdbcc8125777b
Gerrit-Change-Number: 19658
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Hans Peter Freyther <automatic at freyther.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Thu, 15 Dec 2022 14:29:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: Holger Hans Peter Freyther <automatic at freyther.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221215/9f8d4e10/attachment.html>