[Asterisk-code-review] app_macro: Remove deprecated module. (asterisk[master])

[N A]

Attention is currently required from: Michael Bradeen, Richard Mudgett.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19708 )

Change subject: app_macro: Remove deprecated module.
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

Patchset:

PS1: 
> IIRC, I modified stdexten in extensions.conf.sample to use Gosub back when Asterisk 11 was released. […]
Yeah, we could remove stdexten separately since it's not 100% related to this.

A few more nitpicks:

main/cdr.c:              * macros/gosubs from perturbing the CDR application/data

configs/samples/extensions_minivm.conf.sample still has a lot of macro samples. But if you think that should be converted as part of a separate change maybe that's fine.

pbx/pbx_ael.c:          e->command = "ael set debug {read|tokens|macros|contexts|off}";

^-- macro is no longer valid here.

tests/test_voicemail_api.c:             "macrocontext=%s\n"

^-- this is not going to work anymore.

pbx/ael/ael-test also seems to have a ton of obsolete stuff, but I think that will be its own project and we should leave it alone here.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19708
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I830daab293117179b8d61bd4df0d971a1b3d07f6
Gerrit-Change-Number: 19708
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 14 Dec 2022 13:43:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Michael Bradeen <mbradeen at sangoma.com>
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: Richard Mudgett <rmudgett at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221214/04cefb2a/attachment.html>