[Asterisk-code-review] app_macro: Remove deprecated module. (asterisk[master])

N A asteriskteam at digium.com
Tue Dec 13 06:41:23 CST 2022


Attention is currently required from: Michael Bradeen.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19708 )

Change subject: app_macro: Remove deprecated module.
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

Patchset:

PS4: 
lines 101 and 104 of pbx/pbx_ael.c:
find_macro forward declaration should be removed.


File doc/UPGRADE-staging/app_macro_removal.txt:

https://gerrit.asterisk.org/c/asterisk/+/19708/comment/5219a597_9ccd3ea5 
PS2, Line 7: 
> This should also mention all the options to the various applications (e.g. […]
Mentioning in the commit message is fine but the changes also need to be in the UPGRADE file



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19708
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I830daab293117179b8d61bd4df0d971a1b3d07f6
Gerrit-Change-Number: 19708
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Comment-Date: Tue, 13 Dec 2022 12:41:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221213/01d9ba4b/attachment.html>


More information about the asterisk-code-review mailing list