[Asterisk-code-review] app_macro: Remove deprecated module. (asterisk[master])

Michael Bradeen asteriskteam at digium.com
Mon Dec 12 17:30:08 CST 2022


Attention is currently required from: Michael Bradeen.

Hello N A, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/19708

to look at the new patch set (#4).

Change subject: app_macro: Remove deprecated module.
......................................................................

app_macro: Remove deprecated module.

For most modules that interacted with app_macro, this change is limited
to no longer looking for the current context from the macrocontext when
set.  Additionally, the following modules are impacted:

app_dial - no longer supports M^ connected/redirecting macro
app_minivm - samples written using macro will no longer work.
The sample needs a re-write

app_queue - can no longer a macro on the called party's channel.
Use gosub which is currently supported

ccss - no callback macro, gosub only

app_voicemail - no macro support

channel  - remove macrocontext and priority, no connected line or
redirection macro options
options - stdexten is deprecated to gosub as the default and only
pbx - removed macrolock
pbx_dundi - no longer look for macro

snmp - removed macro context, exten, and priority

ASTERISK-30304

Change-Id: I830daab293117179b8d61bd4df0d971a1b3d07f6
---
M addons/chan_ooh323.c
M apps/app_chanspy.c
M apps/app_dial.c
M apps/app_directory.c
M apps/app_followme.c
D apps/app_macro.c
M apps/app_meetme.c
M apps/app_minivm.c
M apps/app_mixmonitor.c
M apps/app_queue.c
M apps/app_stack.c
M apps/app_voicemail.c
M channels/chan_dahdi.c
M channels/chan_pjsip.c
M channels/chan_sip.c
M configs/samples/asterisk.conf.sample
M configs/samples/ccss.conf.sample
M configs/samples/extensions.ael.sample
M configs/samples/extensions.conf.sample
M configs/samples/extensions_minivm.conf.sample
M configs/samples/features.conf.sample
M configs/samples/minivm.conf.sample
M configs/samples/queues.conf.sample
M configs/samples/users.conf.sample
A doc/UPGRADE-staging/app_macro_removal.txt
M funcs/func_callcompletion.c
M include/asterisk/app.h
M include/asterisk/ccss.h
M include/asterisk/channel.h
M include/asterisk/extconf.h
M include/asterisk/options.h
M include/asterisk/pbx.h
M main/app.c
M main/bridge_basic.c
M main/bridge_channel.c
M main/ccss.c
M main/channel.c
M main/channel_internal_api.c
M main/dial.c
M main/features.c
M main/pbx.c
M main/pbx_builtins.c
M main/pickup.c
M menuselect/example_menuselect-tree
M menuselect/test/menuselect-tree
M pbx/pbx_config.c
M pbx/pbx_dundi.c
M res/res_fax.c
M res/snmp/agent.c
M utils/extconf.c
50 files changed, 145 insertions(+), 1,613 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/08/19708/4
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19708
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I830daab293117179b8d61bd4df0d971a1b3d07f6
Gerrit-Change-Number: 19708
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221212/12fdd5e2/attachment.html>


More information about the asterisk-code-review mailing list